Add manual stop on schema diffing algorithm#3119
Merged
andimarek merged 5 commits intographql-java:masterfrom Mar 20, 2023
Merged
Add manual stop on schema diffing algorithm#3119andimarek merged 5 commits intographql-java:masterfrom
andimarek merged 5 commits intographql-java:masterfrom
Conversation
dondonz
approved these changes
Mar 16, 2023
andimarek
requested changes
Mar 16, 2023
Member
andimarek
left a comment
andimarek
left a comment
There was a problem hiding this comment.
Lets not check the Thread flag at all and only use the provided boolean.
Also: mark all new classes as @Internal
| @@ -0,0 +1,7 @@ | |||
| package graphql.schema.diffing; | |||
|
|
|||
| private final AtomicBoolean wasStopped = new AtomicBoolean(false); | ||
|
|
||
| void check() { | ||
| if (Thread.interrupted()) { |
Member
There was a problem hiding this comment.
Lets use only the boolean flag
andimarek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.stop()function toSchemaDiffing.javaand also checks forThread.interrupted()