Ensured that the MANIFEST.MF files is the first entry in the JAR File #3097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first entry in the JAR file as it is required for java.util.jar.JarFile to obtain the manfiest entry which is essential for Sling to work.
Member
|
Hello, thanks so much for opening a PR, I will take a look |
bbakerman
approved these changes
Feb 27, 2023
Member
|
Thanks so much @schaefa for reporting the issues and to top it off, opening a PR with the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as it is required for java.util.jar.JarFile to obtain the manfiest entry which is essential for Sling to work as discussed in #3089. This will fail to work with Sling's bundle installer as it is using JarFile to obtain the manifest and that is not found if it is not the first entry.