Meta Lambda failures - make the code more resilient to class loader challenges #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Feb 19, 2023
bbakerman
commented
Feb 19, 2023
src/test/groovy/graphql/schema/PropertyDataFetcherClassLoadingTest.groovy
Show resolved
Hide resolved
bbakerman
changed the title
bbakerman
commented
Feb 27, 2023
| * Proprs to https://www.baeldung.com/java-string-compile-execute-code where | ||
| * most of this code came from. | ||
| */ | ||
| public class DynamicJavacSupport { |
Member
Author
There was a problem hiding this comment.
I added this to allow is to generate classes in the tests - that are in seperate and diverse class loaders.
Neato!
Contributor
|
I applied this PR to the master branch, built it and used it inside a Felix container and it works. |
dondonz
reviewed
Mar 14, 2023
| static class BrokenClass { | ||
| static { | ||
| // this should prevent it from existing | ||
| throw new RuntimeException("No soup for you!") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JVM has an interesting runtime.
It turns out that in certain cases is possible to use reflection to invoke a certain class method, even if the class loaders of the two bits of code are not visible to each other. However its not possible to create a meta lambda call across class loaders
This has been improved in Java 9 - however are we likely to delay the Java 11 upgrade in graphql-java so this PR does not use the new mechanism
Rather it makes the code more resilient in the face of class cast and linkage errors
This relates to #3095