defaulting the deprecated methods in Coercing #3063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ernir
approved these changes
Dec 28, 2022
Ernir
left a comment
Ernir
left a comment
There was a problem hiding this comment.
Tried this out locally in the project mentioned in this discussion, this provides the migration path I was looking for. :)
Looking forward to this release, thanks a lot!
dondonz
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Coercingis a SPI, leaving the deprecated methods undefaulted means that people MUST implement the old methods even though they won't be calledThis defaults them. It does introduce possible confusion since no methods needs to be implemented like before however this is clear in reality - You need to implement the non deprecated methods and if you don't it will throw an exception