Skip to content

Allow users to disable MultiSourceReader trackData through ParserOptions #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dondonz merged 1 commit into from
Jan 21, 2023
Merged

Allow users to disable MultiSourceReader trackData through ParserOptions #3062

dondonz merged 1 commit into from
Jan 21, 2023

Conversation

@AntaresS
Copy link

@AntaresS AntaresS commented Dec 20, 2022 •
edited
Loading

PR for #3061

This change adds a new option into ParserOptions which is configurable by users so that we can pass it down to the underlying MultiSourceReader to control whether to enable trackData or not.

bbakerman
bbakerman approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement.

@bbakerman bbakerman added this to the 21.0 milestone Dec 28, 2022
@AntaresS
Copy link
Author

AntaresS commented Jan 12, 2023 •
edited
Loading

@bbakerman Since v21 requires java 11 support, I wonder if it can possibly fit into a minor backport release in v19 and/or v20?

@dondonz
Copy link
Member

dondonz commented Jan 12, 2023

@AntaresS We'll consider doing another v20 release when we have a few more PRs to release in a batch

@AntaresS
Copy link
Author

AntaresS commented Jan 13, 2023

@AntaresS We'll consider doing another v20 release when we have a few more PRs to release in a batch

Great. Thanks!

@AntaresS
Copy link
Author

AntaresS commented Jan 20, 2023

@dondonz @bbakerman Can we get an ETA on when a patch release will be made? Thanks.

@dondonz
Copy link
Member

dondonz commented Jan 21, 2023

Hi @AntaresS thanks for asking. We're in the process of formalising a release schedule. When it is finalised we will announce it publicly. Do bear with me as some of the team is on holiday.

@dondonz dondonz merged commit c2887b3 into graphql-java:master Jan 21, 2023
@dondonz dondonz mentioned this pull request Jan 21, 2023
Closed
@bbakerman
Copy link
Member

bbakerman commented Jan 30, 2023

Also know that every commit to master on makes a new maven release. eg 0.0.0-2023-01-27T04-40-05-3be28fca

This allows you to get access to the latest code from Maven / Gradle without needing a numbered release

https://repo1.maven.org/maven2/com/graphql-java/graphql-java/0.0.0-2023-01-27T04-40-05-3be28fca/

@andimarek andimarek modified the milestones: 21.0, April 2023 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbakerman bbakerman bbakerman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

20.1

Development

Successfully merging this pull request may close these issues.

4 participants

@AntaresS @dondonz @bbakerman @andimarek