Resolve TypeReferences in schema applied directives #3054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for raising this PR inlcuding test ... I will need to have a deeper look regarding the actual fix if that is the best way, because I think it should have been handled. |
Contributor
Author
|
The traversal starts from the types and directive definitions, and since schema applied directives aren't reachable from either of those, they get skipped. |
bbakerman
reviewed
Feb 9, 2023
| final Map<String, GraphQLNamedType> typeMap = schema.getTypeMap(); | ||
| List<GraphQLSchemaElement> roots = new ArrayList<>(typeMap.values()); | ||
| roots.addAll(schema.getDirectives()); | ||
| roots.addAll(schema.getSchemaAppliedDirectives()); |
Member
There was a problem hiding this comment.
This makes sense to me @andimarek - these objects are not in the schema (eg linked by other objects) - they are root level objects
bbakerman
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3053