Add missing equals/hashcode methods to relay classes #2988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add equals/hashcode methods to DefaultConnection, DefaultEdge, DefaultPageInfo. graphql-java#2986
bbakerman
approved these changes
Oct 18, 2022
Member
bbakerman
left a comment
bbakerman
left a comment
There was a problem hiding this comment.
Thanks
The tests look spot on
pgr0ss
deleted the
add-missing-equals-hashcode-methods-to-relay-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add equals/hashcode methods to DefaultConnection, DefaultEdge, DefaultPageInfo.
As discussed: #2986
This is my first time using Spock, so please let me know if there's a different or better way to do this testing. I used the tables to try to reduce the test noise.