Avoids allocating a copy of the field names set inside the ES #2981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Oct 5, 2022
| MergedSelectionSet fields = parameters.getFields(); | ||
| Set<String> fieldNames = fields.keySet(); | ||
| List<String> fieldNames = fields.getKeys(); | ||
| Async.CombinedBuilder<FieldValueInfo> futures = Async.ofExpectedSize(fields.size()); |
Member
Author
There was a problem hiding this comment.
the implementation is ImmutabeList.copyOf and hence backed by the original structure
bbakerman
commented
Oct 5, 2022
| public class MergedSelectionSet { | ||
|
|
||
| private final Map<String, MergedField> subFields; | ||
| private final ImmutableMap<String, MergedField> subFields; |
Member
Author
There was a problem hiding this comment.
Make an immutable map of the merged selection set of fields
This preserves order if the original map was a LinkedHashMap (which it is)
dondonz
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix really - but it means that field sub selection is an immutable collection and not copied inside the ES