Remove redundant NaN check, already handled in GraphqlFloatCoercing #2936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed logic belongs inside a scalar's
serializemethod and should not be handled in this location insideExecutionStrategy.We have already handled the
NaNcase insideGraphqlFloatCoercingand we already had aNaNtest inScalarsFloatTest, seeserialize throws exception for invalid input #value.This is an old TODO from 2018. The Float spec has changed since then, now an error is to be raised for non-finite values such as
NaN.Spec: https://spec.graphql.org/draft/#sec-Float
Spec PR: graphql/graphql-spec#778