Fix field visibility bug with enum with enum args #2926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug that happened when the field visibility transformation was applied to a schema that has some type(s) reachable only via directive definitions.
bbakerman
approved these changes
Aug 19, 2022
| // Include directive definitions as roots, since they won't be removed in the filtering process. | ||
| // Some types (enums, input types, etc.) might be reachable only by directive definitions (and | ||
| // not by other types or fields). | ||
| .addAll(schema.getDirectives()) |
Member
There was a problem hiding this comment.
should we have schema.getAdditionalTypes here as well
Member
There was a problem hiding this comment.
I guess this ends up removing types that are no linked (if I recall right) so perhap no
Member
Author
There was a problem hiding this comment.
I think the opposite would happen: types that became unreachable after fields were filtered out would still show up in the final schema, because essentially all types would be root types and thus reachable.
bbakerman
added a commit
that referenced
this pull request
Sep 7, 2022
Fixes a bug that happened when the field visibility transformation was applied to a schema that has some type(s) reachable only via directive definitions.
bbakerman
added a commit
that referenced
this pull request
Sep 7, 2022
…) (#2944) Fixes a bug that happened when the field visibility transformation was applied to a schema that has some type(s) reachable only via directive definitions.
estal011
added a commit
to 8btc-OnePiece/graphql-java
that referenced
this pull request
Jun 6, 2024
* 19.3: (709 commits) use class loader in getResource (graphql-java#3038) Stable port of graphql-java#2940 (graphql-java#2947) Stable port of Diff counts are the same (graphql-java#2946) Stable port of Fix printing directives when they contain something like a formatting specifier (graphql-java#2919) (graphql-java#2920) (graphql-java#2945) Stable port of Fix field visibility bug with enum with enum args (graphql-java#2926) (graphql-java#2944) Stable fix for graphql-java#2943 (graphql-java#2943) Added test fore intersection Xuorig Fix PR - Edge case with GraphQLTypeReference and Schema Transforms (graphql-java#2906) Fix typo in description of skip directive (graphql-java#2915) Add smaller set first optimisation Cheaper calculation for narrowing down possible objects in ENO Handles isDeprecated not being present in the json Defaults Locale when calling validation (graphql-java#2908) DF SelectionSet Benchmark (graphql-java#2893) Test stability (graphql-java#2903) Donna's catch! (graphql-java#2900) Deprecate Apollo Cache Control READY - Stop DOS attacks by making the lexer stop early on evil input. (graphql-java#2892) Bump java-dataloader ahead of release State is passed explicitly to instrumentation and parameters are NOT mutated (graphql-java#2769) ... # Conflicts: # README.md # build.gradle # src/main/java/graphql/GraphQL.java # src/main/java/graphql/Scalars.java # src/main/java/graphql/execution/ValuesResolver.java # src/main/java/graphql/relay/SimpleListConnection.java # src/main/java/graphql/schema/DataFetchingEnvironmentImpl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that happened when the field visibility transformation was applied to a schema that has some types reachable only via directive definitions.