Skip to content

Conversation

@acanda
Copy link
Contributor

@acanda acanda commented Aug 9, 2022

There's a unnecessary apostrophe in the description of the skip directive.

@bbakerman bbakerman added this to the 19.1 milestone Aug 10, 2022
@bbakerman
Copy link
Member

Thanks for this

@bbakerman bbakerman self-requested a review August 10, 2022 00:24
public static final GraphQLDirective SkipDirective = GraphQLDirective.newDirective()
.name("skip")
.description("Directs the executor to skip this field or fragment when the `if`'argument is true.")
.description("Directs the executor to skip this field or fragment when the `if` argument is true.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bbakerman bbakerman merged commit faf6337 into graphql-java:master Aug 10, 2022
@acanda acanda deleted the fix/typo-skip-directive branch August 10, 2022 17:43
estal011 added a commit to 8btc-OnePiece/graphql-java that referenced this pull request Jun 6, 2024
* 19.3: (709 commits)
  use class loader in getResource (graphql-java#3038)
  Stable port of graphql-java#2940 (graphql-java#2947)
  Stable port of Diff counts are the same (graphql-java#2946)
  Stable port of Fix printing directives when they contain something like a formatting specifier (graphql-java#2919) (graphql-java#2920) (graphql-java#2945)
  Stable port of Fix field visibility bug with enum with enum args (graphql-java#2926) (graphql-java#2944)
  Stable fix for graphql-java#2943 (graphql-java#2943)
  Added test fore intersection
  Xuorig Fix PR - Edge case with GraphQLTypeReference and Schema Transforms (graphql-java#2906)
  Fix typo in description of skip directive (graphql-java#2915)
  Add smaller set first optimisation
  Cheaper calculation for narrowing down possible objects in ENO
  Handles isDeprecated not being present in the json
  Defaults Locale when calling validation (graphql-java#2908)
  DF SelectionSet Benchmark (graphql-java#2893)
  Test stability (graphql-java#2903)
  Donna's catch! (graphql-java#2900)
  Deprecate Apollo Cache Control
  READY - Stop DOS attacks by making the lexer stop early on evil input. (graphql-java#2892)
  Bump java-dataloader ahead of release
  State is passed explicitly to instrumentation and parameters are NOT mutated (graphql-java#2769)
  ...

# Conflicts:
#	README.md
#	build.gradle
#	src/main/java/graphql/GraphQL.java
#	src/main/java/graphql/Scalars.java
#	src/main/java/graphql/execution/ValuesResolver.java
#	src/main/java/graphql/relay/SimpleListConnection.java
#	src/main/java/graphql/schema/DataFetchingEnvironmentImpl.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants