remove deferred support #1961
Merged
remove deferred support #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
approved these changes
Jun 21, 2020
Member
bbakerman
left a comment
bbakerman
left a comment
There was a problem hiding this comment.
Its a PITY in some ways but honestly no one was really using it (based on a lack of questions ever about it)
The fact is MANY clients are JS browsers AND browser have no good ways to take a stream of JSON results in a decent fetch API
They are mostly know about fetch "onSuccess / onFailure". The idea of progressively asembling a JSON response its not really a thing that they are familar with
felipe-gdr
pushed a commit
to felipe-gdr/graphql-java
that referenced
this pull request
Jan 18, 2024
Revert "Merge pull request graphql-java#1964 from graphql-java/remove-deferred-2" This reverts commit a0d327d, reversing changes made to 3101f48. Revert "Merge pull request graphql-java#1961 from graphql-java/remove-deferred-support" This reverts commit 3101f48, reversing changes made to 10eeacc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our deferred support was based on the Apollo implementation, but Apollo removed the experimental implementation again and it is currently not supported.
There is also currently a new proposal discussed actively in the GraphQL WG (https://github.com/graphql/graphql-spec/blob/master/rfcs/DeferStream.md) which aims to make deferred/stream part of the standard.
This PR removes the current (not supported in the overall ecosystem) deferred implementation. Our goal should be to add a new official defer support once it is ready.