Skip to content

Some CPU overhead from ChainedInstrumentation #3436

@DanielThomas

Description

@DanielThomas

Describe the bug

We register more than one instrumentation as part of our DGS framework, which leads to ChainedInstrumentation being used. This class shows as a hotspot for field instrumentation in particular. In the case of the application I was looking at, I'd estimate it's 5-8% of the CPU overhead while satisfying queries:

Screenshot 2024-02-05 at 8 53 12 pm

Data fetching for this service is all GRPC/Netty/EVCache, so graphql-java hotspots become more visible that they might otherwise be; this is very likely the worst case for this class.

To Reproduce

Note the overhead of field instrumentation when using chained instrumentations, due to the frequency of beginField calls for any non-trivial query.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions