Building a GraphQL response can fail when the JVM is in the Turkish Locale and a field starts with an i #3385
Description
In our product we were asked to support Turkish on our application server, but graphql-java fails to build a response for any private field with accessors that starts with an i that is inherited from a base class, when in the Turkish locale.
The client received lots of error containing messages such as:
The field at path '/blah/id' was declared as a non null type, but the code involved in retrieving data has wrongly returned a null value. The graphql specification requires that the parent field be set to null, or if that is non nullable that it bubble up null to its parent and so on. The non-nullable type is 'BaseClass' within parent type 'ParentClass'"
I wrote a new test extending the test class PropertyDataFetcherTest.groovy. You should be able to just append the following to the bottom of that class.
class BaseObject {
private String id
String getId() {
return id
}
void setId(String value) {
id = value;
}
}
class OtherObject extends BaseObject {}
def "Can access private property from base class that starts with i in Turkish"() {
given:
Locale oldLocale = Locale.getDefault()
Locale.setDefault(new Locale("tr", "TR"))
def environment = env(new OtherObject(id: "aValue"))
def fetcher = PropertyDataFetcher.fetching("id")
when:
String propValue = fetcher.get(environment)
then:
propValue == 'aValue'
cleanup:
Locale.setDefault(oldLocale)
}
The weird class inheritance was to simulate the equivalent java structure we had and when debugged it appears to follow the same failure path we see in PropertyFetchingImpl::getPropertyViaFieldAccess.
Possible fix
One offending line of code looks to be at PropertyFetchingImpl.java#L216
This code normally converts our property id to the method name getId but when in the Turkish locale it becomes getİd. This obviously fails, and graphql-java's further attempts to figure out a way of accessing this field also fail in our case.
I've tested replacing that line of code with the following (plus the Locale import):
String getterName = prefix + propertyName.substring(0, 1).toUpperCase(Locale.ROOT) + propertyName.substring(1);
and that works in our setup. Locale.ROOT is the suggested fix from the java docs here.