Skip to content

MultiSourceReader has breaking behavioural changes when running on Java 16+ #2709

@jord1e

Description

@jord1e

Describe the bug
Because of JDK-8241020 "LineNumberReader.getLineNumber() behavior is inconsistent with respect to EOF", the MultiSourceReader class behaves incorrectly when running on Java 16+ VMs, even when compiling with Java 8. This causes breaking changes.

The following test cases are failing:
afbeelding

To Reproduce

Run the tests on JDK 16, or higher
Same issue occurs when you compile on JDK 8 and run tests on JDK 16+ (see results below)

For ease of testing you may temporarily clone https://github.com/jord1e/graphql-java/tree/ci-improvements and change the versions in gradle.properties (or checkout jord1e@a1f4f84)

Results can be downloaded here:
https://github.com/jord1e/graphql-java/actions/runs/1778419182

Found whilst working on #2676

Can't figure this one out on myself quickly...

Metadata

Metadata

Assignees

No one assigned

    Labels

    keep-openTells Stale Bot to keep PRs and issues open

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions