Skip to content

Fragment arguments parser#252

Merged
dotansimha merged 2 commits intomainfrom
transform-fragment-arguments
Jun 30, 2021
Merged

Fragment arguments parser#252
dotansimha merged 2 commits intomainfrom
transform-fragment-arguments

Conversation

@n1ru4l
Copy link
Copy Markdown
Collaborator

@n1ru4l n1ru4l commented Jun 4, 2021

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 4, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: e721fed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/fragment-arguments Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@n1ru4l n1ru4l force-pushed the transform-fragment-arguments branch from 11650bd to 043e660 Compare June 4, 2021 08:41
@theguild-bot
Copy link
Copy Markdown
Collaborator

theguild-bot commented Jun 4, 2021 •
edited
Loading

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@envelop/[email protected]

@n1ru4l n1ru4l force-pushed the transform-fragment-arguments branch from 043e660 to 2923c60 Compare June 4, 2021 08:43
@dotansimha dotansimha force-pushed the main branch 2 times, most recently from ce5a34b to beba812 Compare June 13, 2021 08:20
@n1ru4l @dotansimha
wip: implement parser extensions for transforming the fragment argume…
a160a44 
…nt transform syntax into operations without fragment arguments, which are executable by all graphql.js versions

See graphql/graphql-js#3152 for reference
@dotansimha dotansimha force-pushed the transform-fragment-arguments branch from 2923c60 to a160a44 Compare June 30, 2021 11:22
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/envelop/5RnFySgCaCbqRKUbUiwgq57aF9e5
✅ Preview: https://envelop-git-transform-fragment-arguments-theguild.vercel.app

@theguild-bot
Copy link
Copy Markdown
Collaborator

theguild-bot commented Jun 30, 2021 •
edited
Loading

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 298000      ✗ 0     
     data_received..................: 1.2 GB  19 MB/s
     data_sent......................: 59 MB   986 kB/s
   ✓ graphql_context................: avg=7.97µs  min=5.4µs    med=7.3µs  max=5.74ms  p(90)=9µs     p(95)=9.9µs  
   ✓ graphql_execute................: avg=95.51µs min=71.7µs   med=90µs   max=15.42ms p(90)=101.2µs p(95)=111.3µs
   ✓ graphql_parse..................: avg=5.36µs  min=3.3µs    med=4.89µs max=7.31ms  p(90)=6.1µs   p(95)=6.7µs  
   ✓ graphql_validate...............: avg=33.17µs min=23.5µs   med=30.9µs max=10.55ms p(90)=36.8µs  p(95)=40.4µs 
     http_req_blocked...............: avg=2.95µs  min=800ns    med=1.3µs  max=13.1ms  p(90)=2.4µs   p(95)=2.9µs  
     http_req_connecting............: avg=220ns   min=0s       med=0s     max=6.02ms  p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=3.48ms  min=288.31µs med=2.41ms max=43.59ms p(90)=8.18ms  p(95)=11.15ms
       { expected_response:true }...: avg=3.48ms  min=288.31µs med=2.41ms max=43.59ms p(90)=8.18ms  p(95)=11.15ms
     http_req_failed................: 0.00%   ✓ 0           ✗ 149000
     http_req_receiving.............: avg=70.76µs min=12.6µs   med=20µs   max=23.24ms p(90)=34.3µs  p(95)=44µs   
     http_req_sending...............: avg=60.79µs min=5.5µs    med=8.3µs  max=24.92ms p(90)=16.89µs p(95)=20.7µs 
     http_req_tls_handshaking.......: avg=0s      min=0s       med=0s     max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=3.35ms  min=259.81µs med=2.34ms max=43.54ms p(90)=7.66ms  p(95)=10.86ms
     http_reqs......................: 149000  2483.043677/s
     iteration_duration.............: avg=4.01ms  min=508.92µs med=2.8ms  max=51ms    p(90)=9.57ms  p(95)=11.98ms
     iterations.....................: 149000  2483.043677/s
     vus............................: 1       min=1         max=10  
     vus_max........................: 10      min=10        max=10

@dotansimha dotansimha changed the title wip: fragment arguments parser Fragment arguments parser Jun 30, 2021
@dotansimha dotansimha merged commit 1ded0dc into main Jun 30, 2021
@dotansimha dotansimha deleted the transform-fragment-arguments branch June 30, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@n1ru4l @theguild-bot @dotansimha