Fix Playground marking fields as @deprecated when they're not#524
Merged
chris-ramon merged 1 commit intographql-go:masterfrom Nov 25, 2019
Merged
Fix Playground marking fields as @deprecated when they're not#524chris-ramon merged 1 commit intographql-go:masterfrom
chris-ramon merged 1 commit intographql-go:masterfrom
Conversation
chris-ramon
approved these changes
Nov 25, 2019
Member
chris-ramon
left a comment
chris-ramon
left a comment
There was a problem hiding this comment.
LGTM 👍 –– Thanks a lot @MarkKremer 🚢 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #504
In the issue I said that making
DeprecationReasonnillable in the struct is probably better. However, that makes it unnecessarily complicated to assign a string to it. Instead, I fixed the problem by using a resolver that returns nil ifDeprecationReasonis an empty string.