Skip to content

Remove obsolete methods #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sungam3r merged 2 commits into from
Feb 3, 2022
Merged

Remove obsolete methods #693

sungam3r merged 2 commits into from
Feb 3, 2022

Conversation

@sungam3r
Copy link
Member

@sungam3r sungam3r commented Dec 30, 2021 •
edited
Loading

v6 or v7?

Autoapprove works!

@sungam3r sungam3r requested a review from Shane32 December 30, 2021 21:45
@sungam3r sungam3r self-assigned this Dec 30, 2021
@sungam3r sungam3r added BREAKING Breaking changes in either public API or runtime behavior and removed test labels Dec 30, 2021
@sungam3r
Copy link
Member Author

sungam3r commented Dec 30, 2021

CodeQL doesn't work because of preview packages. I think it's OK.

@sungam3r sungam3r mentioned this pull request Dec 30, 2021
Merged
@sungam3r sungam3r linked an issue Dec 30, 2021 that may be closed by this pull request
Rewrite AddGraphQL extensions #654
Closed
@sungam3r sungam3r mentioned this pull request Jan 1, 2022
Merged
@sungam3r
Copy link
Member Author

sungam3r commented Jan 5, 2022

I would remove now, that is for v6.

Shane32
Shane32 approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@Shane32 Shane32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I never reviewed this before, but let's merge it in.

@github-actions github-actions bot added the test label Feb 2, 2022
@Shane32
Copy link
Member

Shane32 commented Feb 3, 2022

Looks like the code coverage isn't working on Windows. Maybe there's some type of change to the build process that it only generates code coverage reports on Linux?

@sungam3r
Copy link
Member Author

sungam3r commented Feb 3, 2022

As intended
изображение

@sungam3r
Copy link
Member Author

sungam3r commented Feb 3, 2022

Prev PR:
изображение

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #693 (f302823) into develop (26dd21a) will increase coverage by 1.03%.
The diff coverage is 37.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #693      +/-   ##
===========================================
+ Coverage    49.92%   50.95%   +1.03%     
===========================================
  Files           68       66       -2     
  Lines         1891     1776     -115     
  Branches       199      188      -11     
===========================================
- Hits           944      905      -39     
+ Misses         888      814      -74     
+ Partials        59       57       -2
Impacted Files Coverage Δ
...spNetCore/GraphQLBuilderAuthorizationExtensions.cs 0.00% <0.00%> (ø)
...softJson/GraphQLBuilderNewtonsoftJsonExtensions.cs 0.00% <0.00%> (ø)
.../Extensions/GraphQLBuilderUserContextExtensions.cs 0.00% <0.00%> (ø)
...s/Extensions/GraphQLBuilderWebSocketsExtensions.cs 100.00% <ø> (ø)
...rc/Core/Extensions/GraphQLBuilderCoreExtensions.cs 50.00% <50.00%> (+35.18%) ⬆️
...TextJson/GraphQLBuilderSystemTextJsonExtensions.cs 100.00% <100.00%> (+42.85%) ⬆️
src/Core/DefaultGraphQLExecuter.cs 0.00% <0.00%> (-25.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26dd21a...f302823. Read the comment docs.

@sungam3r
Copy link
Member Author

sungam3r commented Feb 3, 2022

It was a transient error.

@sungam3r sungam3r merged commit 00f0455 into develop Feb 3, 2022
@sungam3r sungam3r deleted the extension branch February 3, 2022 19:32
@Shane32
Copy link
Member

Shane32 commented Feb 3, 2022

It was a transient error.

Good. I ran the workflow twice and it failed both times. Glad it’s working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shane32 Shane32 Shane32 approved these changes

Assignees

@sungam3r sungam3r

Labels

BREAKING Breaking changes in either public API or runtime behavior documentation test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rewrite AddGraphQL extensions

4 participants

@sungam3r @Shane32 @codecov-commenter