Skip to content

Conversation

@sungam3r
Copy link
Member

@sungam3r sungam3r commented Nov 22, 2021

fixes #544

Just an oversight when migrating on GraphQL.NET v4. Public API for document executer should be changed in v6.

@sungam3r sungam3r added the bugfix Pull request that fixes a bug label Nov 22, 2021
@sungam3r sungam3r requested a review from Shane32 November 22, 2021 13:41
@sungam3r sungam3r self-assigned this Nov 22, 2021
@sungam3r sungam3r added this to the v5.1 milestone Nov 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #653 (7ca3adf) into master (6d22223) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   55.40%   55.66%   +0.25%     
==========================================
  Files          64       64              
  Lines        1545     1545              
  Branches      154      154              
==========================================
+ Hits          856      860       +4     
+ Misses        635      631       -4     
  Partials       54       54              
Impacted Files Coverage Δ
src/Core/Extensions/ServiceCollectionExtensions.cs 39.13% <100.00%> (ø)
....Subscriptions.Abstractions/LogMessagesListener.cs 40.00% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d22223...7ca3adf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong document executer registered for subscription support Subscriptions didnt work out of the box in current examples and readme.md

4 participants