Skip to content

Conversation

@sharppanda
Copy link
Contributor

Fixes #583

@codecov-commenter
Copy link

Codecov Report

Merging #584 (d013cc3) into master (4bb8cc3) will increase coverage by 0.54%.
The diff coverage is 100.00%.

❗ Current head d013cc3 differs from pull request most recent head 5793de2. Consider uploading reports for the commit 5793de2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   54.63%   55.17%   +0.54%     
==========================================
  Files          63       63              
  Lines        1499     1506       +7     
  Branches      151      152       +1     
==========================================
+ Hits          819      831      +12     
+ Misses        627      623       -4     
+ Partials       53       52       -1     
Impacted Files Coverage Δ
src/Transports.AspNetCore/GraphQLHttpMiddleware.cs 92.36% <100.00%> (+1.12%) ⬆️
....Subscriptions.Abstractions/LogMessagesListener.cs 40.00% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb8cc3...5793de2. Read the comment docs.

Copy link
Member

@Shane32 Shane32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but @sungam3r needs to approve it.

@Shane32 Shane32 requested a review from sungam3r May 25, 2021 16:47
@sharppanda
Copy link
Contributor Author

Do you have an ETA when this could be reviewed by @sungam3r ?

@Shane32
Copy link
Member

Shane32 commented Jun 10, 2021

@sungam3r bump

@sungam3r
Copy link
Member

@sharppanda Thanks for fixing this.

Do you have an ETA when this could be reviewed by @sungam3r ?

I had a long break from OSS this year so...just reviewed! LGTM

@sungam3r sungam3r added the enhancement New feature or request label Nov 18, 2021
@sungam3r sungam3r added this to the v5.1 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GraphQL endpoint throwing HTTP 500 on HTTP GET

4 participants