-
Notifications
You must be signed in to change notification settings - Fork 165
GraphQLHttpMiddleware returns 400 when query is missing #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Shane Krueger <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
+ Coverage 54.63% 55.17% +0.54%
==========================================
Files 63 63
Lines 1499 1506 +7
Branches 151 152 +1
==========================================
+ Hits 819 831 +12
+ Misses 627 623 -4
+ Partials 53 52 -1
Continue to review full report at Codecov.
|
Shane32
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but @sungam3r needs to approve it.
|
Do you have an ETA when this could be reviewed by @sungam3r ? |
|
@sungam3r bump |
|
@sharppanda Thanks for fixing this.
I had a long break from OSS this year so...just reviewed! LGTM |
Fixes #583