Add GetDirectiveLocation extension method #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@gao-artur Let's include this in v8 also (parser v9). I don't think I have any other changes to do. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| result = (T)(object)context.ParseInputObjectTypeDefinition(); | ||
| else if (typeof(T) == typeof(GraphQLInputValueDefinition)) | ||
| result = (T)(object)context.ParseInputValueDefinition(); | ||
| result = (T)(object)context.ParseInputValueDefinition(null); |
Check warning
Code scanning / CodeQL
Useless upcast
| result = (T)(object)context.ParseInputValueDefinition(); | ||
| result = (T)(object)context.ParseInputValueDefinition(null); | ||
| else if (typeof(T) == typeof(GraphQLInputFieldDefinition)) | ||
| result = (T)(object)context.ParseInputValueDefinition(false); |
Check warning
Code scanning / CodeQL
Useless upcast
| else if (typeof(T) == typeof(GraphQLInputFieldDefinition)) | ||
| result = (T)(object)context.ParseInputValueDefinition(false); | ||
| else if (typeof(T) == typeof(GraphQLArgumentDefinition)) | ||
| result = (T)(object)context.ParseInputValueDefinition(true); |
Check warning
Code scanning / CodeQL
Useless upcast
gao-artur
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #395 with a non-breaking solution. Not quite ideal, but good enough; argument fields and input object fields now use derived classes, and an extension method to ASTNode provides the directive location.
Other non-breaking options:
Breaking options: