Skip to content

Conversation

@sungam3r
Copy link
Member

See notes in #332.

@sungam3r sungam3r requested a review from Shane32 October 11, 2023 06:39
@sungam3r sungam3r self-assigned this Oct 11, 2023
@sungam3r
Copy link
Member Author

CA2012 nowarn still exists for tests

@codecov-commenter
Copy link

Codecov Report

Merging #349 (ebd092a) into master (cdd6106) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          89       89           
  Lines        4975     4975           
  Branches      494      494           
=======================================
  Hits         4788     4788           
  Misses        187      187           
Files Coverage Δ
src/GraphQLParser/Visitors/SDLPrinterExtensions.cs 100.00% <100.00%> (ø)
src/GraphQLParser/Visitors/SDLSorter.cs 100.00% <100.00%> (ø)

@Shane32
Copy link
Member

Shane32 commented Oct 11, 2023

I did not use AsTask so as to be sure that there was no allocation occurring. But whatever you think.

@Shane32
Copy link
Member

Shane32 commented Oct 11, 2023

Also note for SDLSorter that it is impossible to run asynchronously since it uses a static instance (cannot be derived) and the options class has no async members. (If I remember correctly.)

@sungam3r
Copy link
Member Author

изображение

@sungam3r sungam3r merged commit ab79ea8 into master Oct 11, 2023
@sungam3r sungam3r deleted the as-task branch October 11, 2023 15:42
@Shane32
Copy link
Member

Shane32 commented Oct 11, 2023

Excellent!

Shane32 pushed a commit that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants