Skip to content

FieldArgumentAnalyzer#3755

Merged
gao-artur merged 4 commits intomasterfrom
analyzers/argument
Nov 2, 2023
Merged

FieldArgumentAnalyzer#3755
gao-artur merged 4 commits intomasterfrom
analyzers/argument

Conversation

@gao-artur
Copy link
Copy Markdown
Contributor

@gao-artur gao-artur commented Nov 1, 2023

Rewrite this

Field<StringGraphType>("Text").Argument<StringGraphType, string>(
    "arg",
    "description",
    "MyDefault");

With this

Field<StringGraphType>("Text").Argument<StringGraphType>(
    "arg",
    "description",
    argument => argument.DefaultValue = "MyDefault");

@gao-artur gao-artur added the enhancement New feature or request label Nov 1, 2023
@gao-artur gao-artur added this to the 7.7 milestone Nov 1, 2023
@gao-artur gao-artur requested a review from Shane32 November 1, 2023 20:33
@gao-artur gao-artur self-assigned this Nov 1, 2023
@github-actions github-actions Bot added the documentation An issue or pull request regarding documentation improvements label Nov 1, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 1, 2023

Codecov Report

Merging #3755 (9f14ff1) into master (cba0429) will increase coverage by 0.02%.
The diff coverage is 88.38%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #3755      +/-   ##
==========================================
+ Coverage   84.30%   84.33%   +0.02%     
==========================================
  Files         410      412       +2     
  Lines       18717    18865     +148     
  Branches     2947     2962      +15     
==========================================
+ Hits        15780    15910     +130     
- Misses       2249     2261      +12     
- Partials      688      694       +6
Files Coverage Δ
...Analyzers.CodeFixes/FieldBuilderCodeFixProvider.cs 98.21% <100.00%> (ø)
...QL.Analyzers.CodeFixes/FieldNameCodeFixProvider.cs 100.00% <100.00%> (ø)
src/GraphQL.Analyzers/Extensions.cs 88.46% <100.00%> (+0.46%) ⬆️
src/GraphQL.Analyzers/FieldBuilderAnalyzer.cs 91.54% <100.00%> (ø)
src/GraphQL.Analyzers/FieldNameAnalyzer.cs 92.85% <100.00%> (ø)
src/GraphQL.Analyzers/FieldArgumentAnalyzer.cs 82.35% <82.35%> (ø)
...nalyzers.CodeFixes/FieldArgumentCodeFixProvider.cs 89.18% <89.18%> (ø)

@gao-artur gao-artur mentioned this pull request Nov 1, 2023
Open
10 tasks
@gao-artur gao-artur merged commit ea9b758 into master Nov 2, 2023
@gao-artur gao-artur deleted the analyzers/argument branch November 2, 2023 20:19
@gao-artur gao-artur added the analyzers Changes to analyzers label Nov 19, 2023
@dependabot dependabot Bot mentioned this pull request Feb 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shane32 Shane32 Shane32 approved these changes

Assignees

@gao-artur gao-artur

Labels

analyzers Changes to analyzers documentation An issue or pull request regarding documentation improvements enhancement New feature or request

Projects

None yet

Milestone

7.7

Development

Successfully merging this pull request may close these issues.

3 participants

@gao-artur @codecov-commenter @Shane32