Add discussion of variable definition directives#103
Merged
leebyron merged 2 commits intographql:masterfrom Aug 31, 2018
mjmahone:patch-2
Merged
Add discussion of variable definition directives#103leebyron merged 2 commits intographql:masterfrom mjmahone:patch-2
leebyron merged 2 commits intographql:masterfrom
mjmahone:patch-2
Conversation
See graphql/graphql-spec#510 for background: basically, is the API correct. It matches the API for directives on field argument definitions, and is (I believe) the most glaring "hole" in where we allow you to add directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.