Change example for directive order to use Query or Mutation, not type system#986
Closed
rivantsov wants to merge 1 commit intographql:mainfrom
rivantsov:P31_DirOrder
Closed
Change example for directive order to use Query or Mutation, not type system#986rivantsov wants to merge 1 commit intographql:mainfrom rivantsov:P31_DirOrder
rivantsov wants to merge 1 commit intographql:mainfrom
rivantsov:P31_DirOrder
Conversation
…anguage to Query or Mutation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directives Order Is Significant sub-section is in section "2. Language", which talks about Query language. The directive order example surprisingly uses a type definition, while type system and its SDL had not been introduced yet, they are coming in chapter 3.
Suggest to change it to Query or Mutation example with multiple directives. I could not come up with decent example, just put a comment there, suggestions are welcome.
Note: even if we change chapters order (SDL first, Query language after), it is still better to have an example matching the area that is chapter's focus