Remove "subscriptions is a significant change" sentence#983
Remove "subscriptions is a significant change" sentence#983benjie merged 8 commits intographql:mainfrom rivantsov:P19_change2challenge
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
From Dec WG: "Supporting subscriptions requires a different approach to queries and mutations." -- @mjmahone |
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
My thought is that we shouldn't use the word "challenge" because it's emotive and subjective. It seems that most users building out a GraphQL schema tend to implement queries first, then mutations, then possibly later subscriptions - so for the majority of users it is in fact a change. However, Roman is right that it may not be a change if you support subscriptions from the get-go, so Matt's suggestion is to change the sentence entirely (see above) to be more objective and yet convey similar meaning to the original text.
|
Matt's suggestion:
I am still not quite happy with this. Is it "to queries and mutations" or "COMPARED to queries and mutations"?
|
|
@benjie , can you pls help with this 'code style/pretier' failure, have no idea what to do about it |
|
If you have node installed, in the root of the repo run |
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
This looks good to me. @graphql/tsc can I get another +1?
benjie
changed the title
|
Thanks @Keweiqu and @rivantsov 🙌 |
5 participants
Explanation, current version:
who is changing what? why we assume certain order of building GraphQL service - queries mutations first, then subscriptions. what if I built all in parallel.
I think 'challenge' makes more sense in the context of the section.