Provide explicit ref to Value Completion section#982
Merged
benjie merged 2 commits intographql:mainfrom Dec 8, 2022
rivantsov:P07_SectionRefResultCoerce
Merged
Provide explicit ref to Value Completion section#982benjie merged 2 commits intographql:mainfrom rivantsov:P07_SectionRefResultCoerce
benjie merged 2 commits intographql:mainfrom
rivantsov:P07_SectionRefResultCoerce
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
michaelstaib
reviewed
Aug 3, 2022
benjie
requested changes
Aug 3, 2022
Co-authored-by: Benjie Gillam <[email protected]>
michaelstaib
approved these changes
Aug 3, 2022
benjie
approved these changes
Aug 3, 2022
mjmahone
approved these changes
Dec 7, 2022
benjie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the current version mentions executor (what is that by the way?), and then:
which section is not clear, we do not have 'executor' section. I suggest some rephrasing, and remove 'executor' - it is not an explained concept in the spec.