Move punctuation outside quotation marks#962
Merged
leebyron merged 1 commit intographql:mainfrom Jun 16, 2022
spawnia:patch-4
Merged
Move punctuation outside quotation marks#962leebyron merged 1 commit intographql:mainfrom spawnia:patch-4
leebyron merged 1 commit intographql:mainfrom
spawnia:patch-4
Conversation
As discussed in graphql/graphql-over-http#175 (comment) - @benjie Every variant of the MIT license does it this way, see https://fedoraproject.org/wiki/Licensing:MIT for reference.
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
benjie
approved these changes
Jun 14, 2022
Member
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Though the grammar is "wrong," since the standard license is written in this way I think we should use the standard license formatting. 😞
Member
Author
|
Let this be the change we want to see in the grammar rules, they can be what we make it ✨ |
Collaborator
|
🤷 |
leebyron
added
the
✏️ Editorial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in graphql/graphql-over-http#175 (comment) - @benjie
Every variant of the MIT license does it this way, see https://fedoraproject.org/wiki/Licensing:MIT for reference.