use findDog query from example schema only after defining it#927
Merged
leebyron merged 1 commit intographql:mainfrom Jun 3, 2022
Merged
Conversation
|
✔️ Deploy Preview for graphql-spec-draft ready! 🔨 Explore the source changes: 1854649 🔍 Inspect the deploy log: https://app.netlify.com/sites/graphql-spec-draft/deploys/61eec5787b2a160007db5b16 😎 Browse the preview: https://deploy-preview-927--graphql-spec-draft.netlify.app/draft |
leebyron
added
the
✏️ Editorial
Collaborator
|
Thank you for this improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the validation section there's an example that uses the
findDogquery before actually defining it in the type system. This PR adds the query right at the beginning of the section instead of extending the schema later. It also adds the required selection sets in the all examples that use this query.I also propose renaming the
ComplexInputtype and thecomplexargument to something more verbose that fits into the rest of the schema and makes it a "real world" example.