add note about selection sets in serial execution examples#926
add note about selection sets in serial execution examples#926thomasheyenbrock wants to merge 1 commit intographql:mainfrom
Conversation
|
✔️ Deploy Preview for graphql-spec-draft ready! 🔨 Explore the source changes: 321255e 🔍 Inspect the deploy log: https://app.netlify.com/sites/graphql-spec-draft/deploys/61fbe769d4671a0008c647fc 😎 Browse the preview: https://deploy-preview-926--graphql-spec-draft.netlify.app |
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Thanks for submitting a suggestion 🙌
The spec text here states (emphasis mine):
For example, given the following selection set to be executed serially:
The examples are not GraphQL documents, they are selection sets, your edits turn them into documents but that change is not desired.
|
Aaah, got it 👍 Though it's easy to read over that and there's a bit of ambiguity here in the sense that one can't tell the difference from a selection set to a document using the query shorthand. What do you think about adding a note here to clear this up? |
Let's see what you have in mind 👍 |
thomasheyenbrock
force-pushed
the
editorial/serial-execution-examples
branch
from
053e94d to
321255e
Compare
thomasheyenbrock
changed the title
|
Updated the PR description and replaced the commit with a new one that just adds a note 🙂 |
|
I'm not convinced this is necessary given the text above the example explicitly states |
2 participants
The examples for serial execution in the section
Normal and Serial Executionactually use a query as operation type. This PR proposes to change these examples to mutations (which are actually required to be executed serially).I also added in the variables in the first of these examples for the operation to be valid.