Clarify query shorthand relationship with directives#873
Merged
Conversation
leebyron
approved these changes
May 27, 2021
Collaborator
|
I'll wait to merge until after the spec release cut |
sungam3r
approved these changes
Oct 10, 2021
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec text currently reads:
The word "contains" here is ambiguous, and it makes it sound like the following query is invalid since it "contains" a directive:
{ __typename @skip(if: true) }Really we mean that there is no direcive applied to the operation itself (directly); I've attempted to clarify this without making the text more verbose.