Editorial: Add response stream to Response Section#1135
Merged
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
martinbonnin
approved these changes
Feb 24, 2025
robrichard
changed the title
BoD
approved these changes
Mar 6, 2025
leebyron
approved these changes
Mar 6, 2025
Collaborator
leebyron
left a comment
leebyron
left a comment
There was a problem hiding this comment.
pure win. nice cleanup and makes this more accurate
leebyron
added
the
✏️ Editorial
github-project-automation
Bot
moved this from Planning to review
to Done
in Benjie's GraphQL tasks
This was referenced Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated section 7 to formally define Response as the map returned by graphql query/mutations. I am also adding a definition of "Response Stream" to section 7 as subscriptions are not mentioned in this section. The defer/stream spec edits will also add a definition for an Incremental Stream here.
I also Linked Response Stream in the execution section to this new definition, and made the existing definition of source stream linkable.