Skip to content

Type "must not be {null}" -> "must exist"#1134

Merged
benjie merged 1 commit intomainfrom
type-must-exist
Mar 7, 2025
Merged

Type "must not be {null}" -> "must exist"#1134
benjie merged 1 commit intomainfrom
type-must-exist

Conversation

@benjie
Copy link
Copy Markdown
Member

@benjie benjie commented Feb 10, 2025

Minor editorial fix, we use "must exist" throughout the spec, and in this case it's appropriate to use "must exist" rather than "must not be null".

@benjie benjie added the ✏️ Editorial PR is non-normative or does not influence implementation label Feb 10, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 10, 2025

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 1ab78d0
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/67aa33d44d2a4100071ee80a
😎 Deploy Preview https://deploy-preview-1134--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better terminology 🤩 👍

@benjie benjie merged commit b7c57ea into main Mar 7, 2025
@benjie benjie deleted the type-must-exist branch March 7, 2025 17:14
@github-project-automation github-project-automation Bot moved this from SHIP IT to Done in Benjie's GraphQL tasks Mar 7, 2025
martinbonnin pushed a commit to martinbonnin/graphql-spec that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✏️ Editorial PR is non-normative or does not influence implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants