Spec edits for incremental delivery, Section 3 only#1132
Merged
robrichard merged 15 commits intoincremental-integrationfrom Oct 30, 2025
Merged
Spec edits for incremental delivery, Section 3 only#1132robrichard merged 15 commits intoincremental-integrationfrom
robrichard merged 15 commits intoincremental-integrationfrom
Conversation
yaacovCR
reviewed
Jan 8, 2025
benjie
reviewed
Jan 10, 2025
yaacovCR
pushed a commit
to graphql/graphql-js
that referenced
this pull request
Jan 12, 2025
Updated to reflect spec draft graphql/graphql-spec#1132 Also changed the argument order to match the spec draft
benjie
requested changes
Feb 6, 2025
Member
benjie
left a comment
There was a problem hiding this comment.
Lots of nit-picky comments but I think we're pretty close! Do we have a glossary somewhere? I think we need to be really crisp on terms like "result", "response", "payload" and the like.
d5322ae to
32785b8
Compare
Contributor
Author
|
@benjie I added a rough glossary here: graphql/defer-stream-wg#106, I'll keep refining it as we go |
robrichard
commented
Feb 20, 2025
176172f to
7c0ba73
Compare
mjmahone
approved these changes
Mar 6, 2025
BoD
reviewed
Mar 6, 2025
BoD
approved these changes
Mar 6, 2025
cf072a4 to
47f362c
Compare
0640179 to
b3187e0
Compare
b3187e0 to
3b8799e
Compare
3b8799e to
64dc38f
Compare
leebyron
reviewed
Jul 3, 2025
benjie
requested changes
Jul 24, 2025
Member
benjie
left a comment
There was a problem hiding this comment.
This is looking really good; all my suggestions are minor except the last one which I think warrants some extra work.
ceee9fc to
d1383e4
Compare
Co-authored-by: Benoit 'BoD' Lubek <[email protected]>
d1383e4 to
f8994fc
Compare
benjie
approved these changes
Oct 30, 2025
Member
benjie
left a comment
There was a problem hiding this comment.
Feels good to me! Here's some editorial, plus one potentially major change to discuss (making initialCount static)
benjie
approved these changes
Oct 30, 2025
robrichard
added a commit
that referenced
this pull request
Mar 19, 2026
* Spec edits for incremental delivery, Section 3 * re-order arguments * Apply suggestions from code review Co-authored-by: Benjie <[email protected]> * Address PR feedback * Address PR feedback * Update spec/Section 3 -- Type System.md Co-authored-by: Benoit 'BoD' Lubek <[email protected]> * Update response terminology * Use new execution result terminology * Update order of arguments on @stream * field error -> execution error * update argument order in examples * _subsequent execution result_ > _execution update result_ * Update note to normative section * fix title and link * review feedback --------- Co-authored-by: Benjie <[email protected]> Co-authored-by: Benoit 'BoD' Lubek <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from the full PR (#1110) and targeting an integration branch to aid in review.
Helpful reference material:
Response format examples: graphql/defer-stream-wg#69
Glossary: graphql/defer-stream-wg#106
GraphQL Conf talk: https://www.youtube.com/watch?v=LEyDeNoobT0
Response types