move Field Collection section earlier#1111
Merged
benjie merged 1 commit intographql:benjie/incremental-commonfrom Oct 17, 2024
Merged
move Field Collection section earlier#1111benjie merged 1 commit intographql:benjie/incremental-commonfrom
benjie merged 1 commit intographql:benjie/incremental-commonfrom
Conversation
benjie
approved these changes
Oct 17, 2024
Member
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
This is a more consistent order 👍
leebyron
added a commit
that referenced
this pull request
Jul 1, 2025
* Extract common logic from ExecuteQuery, ExecuteMutation and ExecuteSubscriptionEvent * Change ExecuteSelectionSet to ExecuteGroupedFieldSet * Correct reference to MergeSelectionSets * move Field Collection section earlier (#1111) * Define 'grouped field set' * that -> which * More similar to prior wording * Remove reason from definition * subGroupedFieldSet -> fieldGroupedFieldSet * Add note for clarity * move field collections into one section, section reworking, minor word tweaking, enum * Apply suggestions from code review * Rename 'ExecuteGroupedFieldSet' to 'ExecuteCollectedFields' * Lee editorial + manual merge #1161 * also rename grouped field set -> collected fields map * include changes after merging master * fixup map iterations * editorial --------- Co-authored-by: Yaacov Rydzinski <[email protected]> Co-authored-by: Lee Byron <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for #1039, see #1039 (comment)