Reformat the parts of an execution request#1090
Conversation
benjie
added
the
✏️ Editorial
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mjmahone
left a comment
mjmahone
left a comment
There was a problem hiding this comment.
Approving as this is pure win as-is, feel free to ignore the nits
|
|
||
| Given this information, the result of {ExecuteRequest()} produces the response, | ||
| to be formatted according to the Response section below. | ||
| - {schema}: The schema to use, typically solely provided by the GraphQL service. |
There was a problem hiding this comment.
nit and not-this-PR: GraphQL service is mildly ambiguous, it's the execution service or the executor or something like that?
There was a problem hiding this comment.
Also nit: GraphQL Service capitalized like below?
There was a problem hiding this comment.
We use this term across the spec I believe
| may contain {FragmentDefinition}. | ||
| - {operationName} (optional): The name of the Operation in the Document to | ||
| execute. | ||
| - {variableValues} (optional): Values for any Variables defined by the |
There was a problem hiding this comment.
nit and not-this-pr: it's not quite any variable: as you can omit some and must include others, but rather Values for a subset of Variables... but I'm not sure I can describe that in a more clarifying less ambiguous way.
5 participants
This PR adds names for each of the "pieces of information" that make up an execution request, and then shows how these values are passed into the
ExecuteRequest()algorithm.This is extracted from #976 as discussed at last night's working group. @leebyron
mentioned that this change adds clarity and is a positive editorial change; splitting this change out will help keep the "extensions" PR focused as it undergoes a few iterations.
cc @michaelstaib