enhance(ResolveFieldValue): note that list items may be async#1066
enhance(ResolveFieldValue): note that list items may be async#1066benjie merged 3 commits intographql:mainfrom
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@graphql/tsc -- I think this could count as an editorial change? It is currently implemented within graphql-js on main as part of the incremental delivery alpha/beta, has not been released... |
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Please restore the paragraph breaks which will both minimise the diff and restore the formatting of the note (which has special handling in spec-md).
Done, thanks! |
and some baseline collection language for comparison extracted from graphql#742 Authored-by: Rob Richard <[email protected]>
Review feedback
yaacovCR
force-pushed
the
async-lists
branch
from
7a6fdc0 to
32b7716
Compare
yaacovCR
force-pushed
the
async-lists
branch
from
6a4d7c6 to
32053c0
Compare
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Looks good to me, and despite being non-normative this already aligns with the behavior of GraphQL.js. I think we can flag this as an editorial note.
benjie
added
the
✏️ Editorial
|
@graphql/tsc This PR extends the non-normative note about resolvers being asynchronous to also note that each entry in a list returned from a resolver can itself be asynchronous. Please either approve or express your concerns - thanks! |
benjie
changed the title
4 participants
and some baseline collection language for comparison
extracted from #742