Skip to content

Fix heading level for Required Arguments validation rule#1055

Merged
benjie merged 1 commit intographql:mainfrom
goto-bus-stop:required-args-level
Nov 10, 2023
Merged

Fix heading level for Required Arguments validation rule#1055
benjie merged 1 commit intographql:mainfrom
goto-bus-stop:required-args-level

Conversation

@goto-bus-stop
Copy link
Copy Markdown
Contributor

Currently in the rendered spec, Required Arguments shows up as a sub-rule of "Argument Uniqueness". It's an independent rule so it should show up next to it instead.
image

Currently in the rendered spec, Required Arguments shows up as a
sub-rule of "Argument Uniqueness". It's an independent rule so it should
show up next to it instead.
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 9, 2023

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 901c4a9
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/654cd6c485bd3d0008711eab
😎 Deploy Preview https://deploy-preview-1055--graphql-spec-draft.netlify.app/draft
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Nov 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: goto-bus-stop / name: Renée (901c4a9)

@benjie benjie added the ✏️ Editorial PR is non-normative or does not influence implementation label Nov 9, 2023
Copy link
Copy Markdown
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting!

@benjie
Copy link
Copy Markdown
Member

benjie commented Nov 9, 2023

(You need to sign the CLA before we can merge this fix.)

@goto-bus-stop
Copy link
Copy Markdown
Contributor Author

Done! 😁

@benjie benjie merged commit 56d6107 into graphql:main Nov 10, 2023
@benjie
Copy link
Copy Markdown
Member

benjie commented Nov 10, 2023

Congrats on your first merge; and thanks for the fix! 🙌

@goto-bus-stop goto-bus-stop deleted the required-args-level branch November 10, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✏️ Editorial PR is non-normative or does not influence implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants