RFC: Null-Only-On-Error / Semantically-Non-Null type (asterisk)#1048
Closed
benjie wants to merge 3 commits intographql:mainfrom
Closed
RFC: Null-Only-On-Error / Semantically-Non-Null type (asterisk)#1048benjie wants to merge 3 commits intographql:mainfrom
benjie wants to merge 3 commits intographql:mainfrom
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Author
|
See also directive for disabling null bubbling built on top of this. |
benjie
changed the title
This was referenced Nov 22, 2023
benjie
force-pushed
the
asterisk
branch
3 times, most recently
from
8395fd5 to
23fa23b
Compare
Member
Author
|
Closed in favour of #1065 |
benjie
added
the
🌱 Superseded (RFC X)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #1046. Here's an updated description:
Inspired by @captbaritone's True Nullability Schema discussion (graphql/graphql-wg#1394) and following @fotoetienne's excellent talk at GraphQLConf and feedback on my resulting PR #1046, I am proposing that we introduce a new wrapper type, the "Null-Only-On-Error" type, represented via asterisk
*. This new type walks the line between the default nullable types and the existing Non-Null type wrapper - it states that the value may only be {null} if a field error has been raised - i.e. it represents the "true nullability" of the field, whilst still acting as an error boundary to avoid null propagation.Critically, this type would "evaporate" for legacy clients, appearing the same as a nullable field. (This is enabled via the
includeNullOnlyOnErrorargument to the__Field.typefield, which defaults tofalse.)This is a much more complete RFC that #1046 was, and happily leverages a lot of the existing behavior of the spec.