Add explicit definition for BlockString#1042
Merged
benjie merged 2 commits intographql:mainfrom Sep 8, 2023
Merged
Conversation
benjie
added
the
✏️ Editorial
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Shane32
approved these changes
Aug 31, 2023
mjmahone
approved these changes
Sep 7, 2023
robrichard
approved these changes
Sep 7, 2023
calvincestari
approved these changes
Sep 7, 2023
martinbonnin
approved these changes
Sep 7, 2023
Member
Author
|
With all these approvals I'm going to go ahead and merge this; we can always undo it if we need to 👍 Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @sungam3r in #899, we state:
However, we don't have a definition for
BlockString.I've elevated
BlockStringto be its own entity, andStringValuenow uses that definition instead.GraphQL.js already has a BlockString token type: https://github.com/graphql/graphql-js/blob/b12dcffe83098922dcc6c0ec94eb6fc032bd9772/src/language/tokenKind.ts#L27 so I think this is just an edit to reflect reality and doesn't really require the RFC process.
@graphql/tsc Can I get some +1s? I'll also add it to the Sept 7 WG in case anyone feels we shouldn't do this.