Implement changes for executable descriptions#4482
Merged
JoviDeCroock merged 2 commits into16.x.xfrom Oct 13, 2025
Merged
Conversation
Co-Authored-By: fotoetienne <[email protected]>
JoviDeCroock
force-pushed
the
executable-descriptions
branch
from
963d23d to
7812f1f
Compare
JoviDeCroock
added
spec RFC
phryneas
approved these changes
Sep 20, 2025
Contributor
phryneas
left a comment
phryneas
left a comment
There was a problem hiding this comment.
This looks good to me, only one stylistic remark.
JoviDeCroock
force-pushed
the
executable-descriptions
branch
from
7812f1f to
b515bf1
Compare
JoviDeCroock
force-pushed
the
executable-descriptions
branch
from
b515bf1 to
b6a04a7
Compare
martinbonnin
approved these changes
Oct 13, 2025
3 tasks
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Feb 17, 2026
Revives and addresses comments from graphql#4430 This is already in the spec and the impl is lagging behind so we might need to get this in 😅 --------- Co-authored-by: fotoetienne <[email protected]>
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Feb 17, 2026
Revives and addresses comments from graphql#4430 This is already in the spec and the impl is lagging behind so we might need to get this in 😅 Co-authored-by: fotoetienne <[email protected]>
yaacovCR
added a commit
that referenced
this pull request
Feb 17, 2026
see original PR #4482 for more details Co-authored-by: Jovi De Croock <[email protected]> Co-authored-by: fotoetienne <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revives and addresses comments from #4430
This is already in the spec and the impl is lagging behind so we might need to get this in 😅