No {Ignored} tokens when parsing schema coordinates#4450
No {Ignored} tokens when parsing schema coordinates#4450JoviDeCroock merged 10 commits intographql:schema-coordinatesfrom
{Ignored} tokens when parsing schema coordinates#4450Conversation
This reverts commit ed6f978.
- Add support for meta-fields (e.g. `__typename`) - Add support for introspection types - Revert back from FieldCoordinate+ValueCoordinate -> MemberCoordinate
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@magicmark I was starting to write an alternative here, but decided to just implement it, so check out #4451 - it adds a single commit on top of this PR that refactors to using an alternative lexer for schema coordinates. (If you like it just cherry-pick that commit into this PR and we can close the other one.) |
|
@benjie done! cherry picked. I also added a test for |
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Looks good to me, but @JoviDeCroock / @yaacovCR should sign off in the changes to the public API
| describe('SchemaCoordinateLexer', () => { | ||
| it('can be stringified', () => { | ||
| const lexer = new SchemaCoordinateLexer(new Source('Name.field')); | ||
| expect(Object.prototype.toString.call(lexer)).to.equal( |
There was a problem hiding this comment.
This should be roughly equivalent?
| expect(Object.prototype.toString.call(lexer)).to.equal( | |
| expect(String(lexer)).to.equal( |
There was a problem hiding this comment.
deferring to prior art / established convention https://github.com/search?q=repo%3Agraphql%2Fgraphql-js%20Object.prototype.toString.call&type=code
(but I agree with you)
3 participants
I took a stab at @benjie's suggestion (which I 100% agree with) to disallow ignored tokens in schema coordinates.
(This caught an instance of whitespace in on of our tests!)
cc @yaacovCR @martinbonnin