Make deprecated.reason non-nullable #4299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
changed the title
JoviDeCroock
suggested changes
Nov 22, 2024
Contributor
JoviDeCroock
left a comment
JoviDeCroock
left a comment
There was a problem hiding this comment.
This should probably get targeted at main as in 16.x.x it would be a breaking change
martinbonnin
force-pushed
the
non-nullable-deprecation-reason
branch
from
935261b to
a95392b
Compare
Author
|
@JoviDeCroock thanks for catching this 🙏 Base branch is updated! |
JoviDeCroock
approved these changes
Nov 22, 2024
yaacovCR
added
the
spec RFC
Contributor
|
Approved! ensure this goes in a major version change since it could cause type recompiles which might have CI implications for some users |
yaacovCR
approved these changes
Dec 5, 2024
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See graphql/graphql-spec#1040