Skip to content

Include kind in the types#4222

Merged
JoviDeCroock merged 1 commit intomainfrom
fix-introspeciton-type
Oct 11, 2024
Merged

Include kind in the types#4222
JoviDeCroock merged 1 commit intomainfrom
fix-introspeciton-type

Conversation

@JoviDeCroock
Copy link
Copy Markdown
Contributor

@JoviDeCroock JoviDeCroock commented Oct 10, 2024 •
edited
Loading

Supersedes #3910
Fixes #3909
Fixes #3409

This puts the Selection-set in line with the expected type

@JoviDeCroock JoviDeCroock requested a review from a team as a code owner October 10, 2024 10:14
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 98fc85f
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6707a8efb9545900087ac4d9
😎 Deploy Preview https://deploy-preview-4222--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 10, 2024

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@JoviDeCroock JoviDeCroock added the PR: bug fix 🐞 requires increase of "patch" version number label Oct 11, 2024
@yaacovCR yaacovCR mentioned this pull request Oct 11, 2024
Closed
@yaacovCR
Copy link
Copy Markdown
Contributor

yaacovCR commented Oct 11, 2024

An issue here is that we are still missing fields/interfaces in that root type position, and doesn't seem to make sense to duplicate those...

Alternative in #4224 is not workable yet.

@JoviDeCroock
Copy link
Copy Markdown
Contributor Author

JoviDeCroock commented Oct 11, 2024

@yaacovCR not sure what you mean 😅

@yaacovCR
Copy link
Copy Markdown
Contributor

yaacovCR commented Oct 11, 2024 •
edited
Loading

graphql-js/src/utilities/getIntrospectionQuery.ts

Lines 227 to 234 in 45e28a5

export interface IntrospectionObjectType {
readonly kind: 'OBJECT';
readonly name: string;
readonly description?: Maybe<string>;
readonly fields: ReadonlyArray<IntrospectionField>;
readonly interfaces: ReadonlyArray<
IntrospectionNamedTypeRef<IntrospectionInterfaceType>
>;

The full correct type needs more than the kind

@JoviDeCroock
Copy link
Copy Markdown
Contributor Author

JoviDeCroock commented Oct 11, 2024

@yaacovCR that is incorrect, the type for root-types is the following

graphql-js/src/utilities/getIntrospectionQuery.ts

Line 311 in 45e28a5

export interface IntrospectionNamedTypeRef<

@JoviDeCroock JoviDeCroock merged commit 6a379a5 into main Oct 11, 2024
This was referenced Oct 11, 2024
Closed
Merged
@JoviDeCroock JoviDeCroock deleted the fix-introspeciton-type branch October 13, 2024 14:34
JoviDeCroock added a commit that referenced this pull request Oct 13, 2024
@JoviDeCroock
Backport introspection type fix (#4226)
2562ce0 
Backports #4222
Supersedes #3910
Fixes #3909
Fixes #3409
@jasonkuhrt jasonkuhrt mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaacovCR yaacovCR yaacovCR approved these changes

Assignees

No one assigned

Labels

PR: bug fix 🐞 requires increase of "patch" version number

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoviDeCroock @yaacovCR