Skip to content

improve new leaf type parseConstLiteral() method #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yaacovCR merged 2 commits into from
Oct 13, 2024
Merged

improve new leaf type parseConstLiteral() method #4218

yaacovCR merged 2 commits into from
Oct 13, 2024

Conversation

@yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Oct 7, 2024 •
edited
Loading

the new method was introduced in #3812 with upgrade path improved in #4209.

This PR completes polishes this work a bit:

  1. The method is renamed to coerceInputLiteral() following the naming convention suggested in Rename Coercion functions #2357, with the other methods to be renamed in later PRs.
  2. The type of the method GraphQLScalarInputLiteralCoercer is exported, which was not done in the initial work. The old GraphQLScalarLiteralParser type is deprecated.

@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Oct 7, 2024
@yaacovCR yaacovCR requested a review from a team as a code owner October 7, 2024 11:55
@netlify
Copy link

netlify bot commented Oct 7, 2024 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit e69fd0d
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/670beea33bff20000814654e
😎 Deploy Preview https://deploy-preview-4218--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 7, 2024

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the title rename parseConstValue() method to coerceInputLiteral() polish: refine new leaf type parseConstLiteral() method Oct 7, 2024
@yaacovCR yaacovCR changed the title polish: refine new leaf type parseConstLiteral() method improve new leaf type parseConstLiteral() method Oct 7, 2024
@yaacovCR yaacovCR force-pushed the rename-leaf-type-methods branch from 71b6b66 to cd6f9f6 Compare October 13, 2024 15:54
@yaacovCR yaacovCR force-pushed the rename-leaf-type-methods branch from cd6f9f6 to e69fd0d Compare October 13, 2024 16:00
@yaacovCR yaacovCR merged commit 805e3c3 into graphql:main Oct 13, 2024
@yaacovCR yaacovCR deleted the rename-leaf-type-methods branch October 13, 2024 16:05
This was referenced Oct 15, 2024
Merged
Closed
yaacovCR added a commit that referenced this pull request Oct 17, 2024
@yaacovCR
rename serialize and parseValue methods (#4241)
44e5d9a 
finish addressing #2357, started in #4218
@jasonkuhrt jasonkuhrt mentioned this pull request Oct 29, 2024
Merged
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 13, 2025
@yaacovCR
improve new leaf type parseConstLiteral() method (graphql#4218)
109456a 
the new method was introduced in graphql#3812 with upgrade path improved in
graphql#4209.

This PR completes polishes this work a bit:

1. The method is renamed to `coerceInputLiteral()` following the naming
convention suggested in graphql#2357, with the other methods to be renamed in
later PRs.
2. The type of the method `GraphQLScalarInputLiteralCoercer` is
exported, which was not done in the initial work. The old
`GraphQLScalarLiteralParser` type is deprecated.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
improve new leaf type parseConstLiteral() method (graphql#4218)
02d731e 
the new method was introduced in graphql#3812 with upgrade path improved in
graphql#4209.

This PR completes polishes this work a bit:

1. The method is renamed to `coerceInputLiteral()` following the naming
convention suggested in graphql#2357, with the other methods to be renamed in
later PRs.
2. The type of the method `GraphQLScalarInputLiteralCoercer` is
exported, which was not done in the initial work. The old
`GraphQLScalarLiteralParser` type is deprecated.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
rename serialize and parseValue methods (graphql#4241)
b015140 
finish addressing graphql#2357, started in graphql#4218
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
improve new leaf type parseConstLiteral() method (graphql#4218)
b9d30ba 
the new method was introduced in graphql#3812 with upgrade path improved in
graphql#4209.

This PR completes polishes this work a bit:

1. The method is renamed to `coerceInputLiteral()` following the naming
convention suggested in graphql#2357, with the other methods to be renamed in
later PRs.
2. The type of the method `GraphQLScalarInputLiteralCoercer` is
exported, which was not done in the initial work. The old
`GraphQLScalarLiteralParser` type is deprecated.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
rename serialize and parseValue methods (graphql#4241)
06f4200 
finish addressing graphql#2357, started in graphql#4218
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
improve new leaf type parseConstLiteral() method (graphql#4218)
ca52f8e 
the new method was introduced in graphql#3812 with upgrade path improved in
graphql#4209.

This PR completes polishes this work a bit:

1. The method is renamed to `coerceInputLiteral()` following the naming
convention suggested in graphql#2357, with the other methods to be renamed in
later PRs.
2. The type of the method `GraphQLScalarInputLiteralCoercer` is
exported, which was not done in the initial work. The old
`GraphQLScalarLiteralParser` type is deprecated.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
rename serialize and parseValue methods (graphql#4241)
c495575 
finish addressing graphql#2357, started in graphql#4218
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
improve new leaf type parseConstLiteral() method (graphql#4218)
e0e0c27 
the new method was introduced in graphql#3812 with upgrade path improved in
graphql#4209.

This PR completes polishes this work a bit:

1. The method is renamed to `coerceInputLiteral()` following the naming
convention suggested in graphql#2357, with the other methods to be renamed in
later PRs.
2. The type of the method `GraphQLScalarInputLiteralCoercer` is
exported, which was not done in the initial work. The old
`GraphQLScalarLiteralParser` type is deprecated.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
rename serialize and parseValue methods (graphql#4241)
b0e0efd 
finish addressing graphql#2357, started in graphql#4218
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
improve new leaf type parseConstLiteral() method (graphql#4218)
bb77627 
the new method was introduced in graphql#3812 with upgrade path improved in
graphql#4209.

This PR completes polishes this work a bit:

1. The method is renamed to `coerceInputLiteral()` following the naming
convention suggested in graphql#2357, with the other methods to be renamed in
later PRs.
2. The type of the method `GraphQLScalarInputLiteralCoercer` is
exported, which was not done in the initial work. The old
`GraphQLScalarLiteralParser` type is deprecated.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
rename serialize and parseValue methods (graphql#4241)
100c114 
finish addressing graphql#2357, started in graphql#4218
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
improve new leaf type parseConstLiteral() method (graphql#4218)
663f499 
the new method was introduced in graphql#3812 with upgrade path improved in
graphql#4209.

This PR completes polishes this work a bit:

1. The method is renamed to `coerceInputLiteral()` following the naming
convention suggested in graphql#2357, with the other methods to be renamed in
later PRs.
2. The type of the method `GraphQLScalarInputLiteralCoercer` is
exported, which was not done in the initial work. The old
`GraphQLScalarLiteralParser` type is deprecated.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
rename serialize and parseValue methods (graphql#4241)
7c92987 
finish addressing graphql#2357, started in graphql#4218
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
improve new leaf type parseConstLiteral() method (graphql#4218)
42b2da9 
the new method was introduced in graphql#3812 with upgrade path improved in
graphql#4209.

This PR completes polishes this work a bit:

1. The method is renamed to `coerceInputLiteral()` following the naming
convention suggested in graphql#2357, with the other methods to be renamed in
later PRs.
2. The type of the method `GraphQLScalarInputLiteralCoercer` is
exported, which was not done in the initial work. The old
`GraphQLScalarLiteralParser` type is deprecated.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
rename serialize and parseValue methods (graphql#4241)
1e52077 
finish addressing graphql#2357, started in graphql#4218
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 19, 2025
@yaacovCR
improve new leaf type parseConstLiteral() method (graphql#4218)
d18f3eb 
the new method was introduced in graphql#3812 with upgrade path improved in
graphql#4209.

This PR completes polishes this work a bit:

1. The method is renamed to `coerceInputLiteral()` following the naming
convention suggested in graphql#2357, with the other methods to be renamed in
later PRs.
2. The type of the method `GraphQLScalarInputLiteralCoercer` is
exported, which was not done in the initial work. The old
`GraphQLScalarLiteralParser` type is deprecated.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 19, 2025
@yaacovCR
rename serialize and parseValue methods (graphql#4241)
226db79 
finish addressing graphql#2357, started in graphql#4218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yaacovCR @JoviDeCroock