incremental: introduce IncrementalGraph class to manage tree of subsequent results #4094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
iterate-after
branch
5 times, most recently
from
3d0b369 to
2cfae02
Compare
yaacovCR
changed the title
yaacovCR
added
the
PR: polish 💅
yaacovCR
force-pushed
the
iterate-after
branch
3 times, most recently
from
ba4733c to
737488d
Compare
yaacovCR
changed the title
This was referenced May 30, 2024
yaacovCR
force-pushed
the
iterate-after
branch
3 times, most recently
from
cba24de to
3dc822b
Compare
robrichard
reviewed
May 31, 2024
yaacovCR
force-pushed
the
iterate-after
branch
4 times, most recently
from
dfd48fb to
32272a6
Compare
… set results to reduce mutation
…grouped field sets error
yaacovCR
commented
Jun 4, 2024
src/execution/IncrementalGraph.ts
Outdated
Comment on lines
207
to
208
| // TODO: add test case? | ||
| /* c8 ignore next 3 */ |
Contributor
Author
There was a problem hiding this comment.
these lines can be removed, a test case was added
robrichard
approved these changes
Jun 4, 2024
yaacovCR
added a commit
that referenced
this pull request
Jun 12, 2024
The incremental graph can handle a stream as a stream, rather than creating a linked list where each incremental data record also includes the next record in addition to any new defers and/or streams. Enables easily batching all available stream items within the same incremental entry. Depends on #4094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Graph object exposes an iterator for the completed incremental data such that the Incremental Publisher can properly be conceptualized as an operator on a stream, similar to the spec changes.
depends on #4099