Skip to content

incremental: introduce GraphQLWrappedResult to avoid filtering#4026

Merged
yaacovCR merged 27 commits intographql:mainfrom
yaacovCR:take-two
Apr 18, 2024
Merged

incremental: introduce GraphQLWrappedResult to avoid filtering#4026
yaacovCR merged 27 commits intographql:mainfrom
yaacovCR:take-two

Conversation

@yaacovCR
Copy link
Copy Markdown
Contributor

@yaacovCR yaacovCR commented Mar 10, 2024 •
edited
Loading

following graphql/graphql-spec#1077

now part of the following PR stack, with the laters PRs extracted from this one

#4026: incremental: introduce GraphQLWrappedResult to avoid filtering
#4050: perf: allow skipping of field plan generation
#4051: perf: introduce completePromisedListItemValue
#4052: refactor: introduce completeIterableValue
#4053: perf: optimize completion loops
#4046: perf: use undefined for empty

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 10, 2024 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 6e44e3a
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66202c810a7566000827f3b9
😎 Deploy Preview https://deploy-preview-4026--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 10, 2024

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR force-pushed the take-two branch 2 times, most recently from 5c12269 to 2665ebd Compare March 11, 2024 10:49
This was referenced Mar 11, 2024
Merged
Closed
@yaacovCR

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 12, 2024

@github-actions publish-pr-on-npm

@yaacovCR The latest changes of this PR are available on NPM as
graphql@17.0.0-alpha.3.canary.pr.4026.5922420b3b235970ee230497190e28c8290c8f16
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-4026

@yaacovCR yaacovCR mentioned this pull request Mar 12, 2024
Closed
@graphql graphql deleted a comment from github-actions Bot Mar 17, 2024
@yaacovCR

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 17, 2024

@github-actions publish-pr-on-npm

@yaacovCR The latest changes of this PR are available on NPM as
graphql@17.0.0-alpha.3.canary.pr.4026.5e657d31b3abdc38acd6bb21c50ed3a41aa33905
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-4026

@graphql graphql deleted a comment from github-actions Bot Mar 19, 2024
@yaacovCR

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2024

@github-actions publish-pr-on-npm

@yaacovCR The latest changes of this PR are available on NPM as
graphql@17.0.0-alpha.3.canary.pr.4026.d2f30cc0780dd436b1a05aa23dfa28c83da7d033
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-4026

@graphql graphql deleted a comment from github-actions Bot Mar 19, 2024
This was referenced Mar 20, 2024
Closed
Closed
Closed
@yaacovCR yaacovCR force-pushed the take-two branch 2 times, most recently from 522b53a to 5644ddf Compare March 20, 2024 17:45
@yaacovCR yaacovCR mentioned this pull request Mar 21, 2024
Closed
@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Mar 21, 2024
@yaacovCR

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 28, 2024

@github-actions publish-pr-on-npm

@yaacovCR The latest changes of this PR are available on NPM as
graphql@17.0.0-alpha.3.canary.pr.4026.1140ceffaf9629dd46a16d4fd28479240752f6eb
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-4026

@yaacovCR

This comment has been minimized.

Sign in to view
@yaacovCR yaacovCR merged commit 05e7a29 into graphql:main Apr 18, 2024
@yaacovCR yaacovCR deleted the take-two branch April 18, 2024 13:46
yaacovCR added a commit that referenced this pull request Apr 19, 2024
@yaacovCR @robrichard
perf: allow skipping of field plan generation (#4050)
6d777e6 
in the non-deferred case.

depends on #4026

---------

Co-authored-by: Rob Richard <[email protected]>
@yaacovCR yaacovCR mentioned this pull request May 9, 2024
Closed
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Jun 3, 2024
@yaacovCR
incremental(stream): revert test logic
266fd70 
Test logic was inadvertently altered in graphql#4026.

Tests still pass, just fixing logic.
@yaacovCR yaacovCR mentioned this pull request Jun 3, 2024
Merged
yaacovCR added a commit that referenced this pull request Jun 3, 2024
@yaacovCR
incremental(stream): revert test logic (#4101)
62d347d 
Test logic was inadvertently altered in #4026.

Tests still pass, just fixing logic.
@jasonkuhrt jasonkuhrt mentioned this pull request Oct 29, 2024
Merged
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
@yaacovCR
polish(execute): add test for combination of sync/async errors
4e05bb5 
extracted from graphql#4026
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 13, 2025
@yaacovCR
polish(execute): add test for combination of sync/async errors
093375e 
extracted from graphql#4026
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
polish(execute): add test for combination of sync/async errors
9b4a5fd 
extracted from graphql#4026
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
polish(execute): add test for combination of sync/async errors
ba85fb0 
extracted from graphql#4026
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
polish(execute): add test for combination of sync/async errors
03ae838 
extracted from graphql#4026
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
polish(execute): add test for combination of sync/async errors
f11222c 
extracted from graphql#4026
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
polish(execute): add test for combination of sync/async errors
8c158c5 
extracted from graphql#4026
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 22, 2025
@yaacovCR
polish(execute): add test for combination of sync/async errors
1b25c9b 
extracted from graphql#4026
yaacovCR added a commit that referenced this pull request Dec 22, 2025
@yaacovCR
polish(execute): add test for combination of sync/async errors
68c1ff0 
extracted from #4026
yaacovCR added a commit that referenced this pull request Dec 22, 2025
@yaacovCR
polish(execute): add test for combination of sync/async errors
fd3c54a 
extracted from #4026
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Jan 27, 2026
@yaacovCR
polish(execute): add test for combination of sync/async errors
0f5452f 
extracted from graphql#4026
yaacovCR added a commit that referenced this pull request Feb 22, 2026
@yaacovCR
polish(execute): add test for combination of sync/async errors
9aa0fa9 
extracted from #4026
yaacovCR added a commit that referenced this pull request Feb 23, 2026
@yaacovCR
polish(execute): add test for combination of sync/async errors
a1c6bee 
extracted from #4026
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
polish(execute): add test for combination of sync/async errors
9bab9f1 
extracted from #4026
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
polish(execute): add test for combination of sync/async errors
419c486 
extracted from #4026
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
polish(execute): add test for combination of sync/async errors
87d0960 
extracted from #4026
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
polish(execute): add test for combination of sync/async errors
98b15bc 
extracted from #4026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robrichard robrichard robrichard approved these changes

@saihaj saihaj saihaj approved these changes

Assignees

No one assigned

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaacovCR @robrichard @saihaj