Skip to content

Add support for @oneOf directives in printSchema#3969

Merged
saihaj merged 1 commit intographql:mainfrom
hayes:print-oneOf
Nov 10, 2023
Merged

Add support for @oneOf directives in printSchema#3969
saihaj merged 1 commit intographql:mainfrom
hayes:print-oneOf

Conversation

@hayes
Copy link
Copy Markdown
Contributor

@hayes hayes commented Sep 10, 2023

fixes #3968

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 10, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 4c544cd
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64ff5a608c128a0008727170
😎 Deploy Preview https://deploy-preview-3969--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread src/utilities/__tests__/printSchema-test.ts
Comment thread src/utilities/printSchema.ts Outdated
@github-actions
Copy link
Copy Markdown

Hi @hayes, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@hayes
Copy link
Copy Markdown
Contributor Author

hayes commented Sep 22, 2023

anything else you need from my end to get this merged?

Copy link
Copy Markdown
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this omission @hayes; this is critical!

@benjie

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 7, 2023

@github-actions publish-pr-on-npm

@benjie The latest changes of this PR are available on NPM as
graphql@17.0.0-alpha.3.canary.pr.3969.83688beb16ecba5a0495158c3c2b3684730579bf
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-3969

@benjie
Copy link
Copy Markdown
Member

benjie commented Nov 9, 2023

@graphql/graphql-js-reviewers This seems like an easy merge now all the feedback has been addressed? 🙌

@saihaj saihaj requested a review from IvanGoncharov November 10, 2023 01:19
@saihaj saihaj merged commit 0b7590f into graphql:main Nov 10, 2023
@benjie benjie added the PR: bug fix 🐞 requires increase of "patch" version number label Jun 21, 2024
benjie pushed a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: bug fix 🐞 requires increase of "patch" version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Printing the @oneOf directive

5 participants