introduce new IncrementalPublisher class#3894
Merged
yaacovCR merged 3 commits intographql:mainfrom Jun 17, 2023
Merged
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
changed the title
yaacovCR
changed the title
yaacovCR
changed the title
yaacovCR
force-pushed
the
extract
branch
9 times, most recently
from
4296109 to
d106636
Compare
yaacovCR
force-pushed
the
extract
branch
2 times, most recently
from
d4baa03 to
d55deae
Compare
yaacovCR
force-pushed
the
extract
branch
5 times, most recently
from
1d889d4 to
97d49e2
Compare
yaacovCR
force-pushed
the
extract
branch
3 times, most recently
from
ec1f103 to
202f06b
Compare
yaacovCR
changed the title
IvanGoncharov
previously requested changes
Jun 9, 2023
Member
IvanGoncharov
left a comment
IvanGoncharov
left a comment
There was a problem hiding this comment.
Sadly, I'm not in the context of this code :(
So I think @robrichard is the most knowledgeable person on this topic, so I he approves, let's merge this one.
P.S. From a general code quality standpoint, it's good after you add missing private attributes.
= iterate only through completed items
= remove extra ticks by making the publisher manage changes to its state synchronously.
= use children array instead of promises to manage hierarchy
= have IncrementalPublisher instantiate new IncrementalDataRecords
= The new publisher sometimes cause an empty `{ hasNext: false }` to be emitted. In particular, because the publisher is faster than it was, it may emit a stream result before the stream's asynchronous iterator has completed.
= The new publisher may sometimes reduce the number of `{ hasNext: false }` records that are emitted. For example, when errors on the initial result filter all subsequent results, this now happens synchronously, and so the publisher knows immediately that there are no subsequent results, such that there is no need for an empty final payload.
Contributor
Author
done! a27ea60 |
= requires reordering of methods because of eslint rule `@typescript-eslint/member-ordering` = adds underscore to private `_initialResult` property for consistency
robrichard
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #3886
depends on #3903
more refactors from the without-branching branch, a bit more fundamental than #3891
[set as patch release because it does have an observable effect on the number of payloads, see below]
= iterate only through completed items
= remove extra ticks by making the publisher manage changes to its state synchronously.
= use children array instead of promises to manage hierarchy
= have IncrementalPublisher instantiate new IncrementalDataRecords
= The new publisher sometimes cause an empty
{ hasNext: false }to be emitted. In particular, because the publisher is faster than it was, it may emit a stream result before the stream's asynchronous iterator has completed.= The new publisher may sometimes reduce the number of
{ hasNext: false }records that are emitted. For example, when errors on the initial result filter all subsequent results, this now happens synchronously, and so the publisher knows immediately that there are no subsequent results, such that there is no need for an empty final payload.