Skip to content

execute: code refactors related to steam/defer#3878

Merged
IvanGoncharov merged 6 commits intographql:mainfrom
yaacovCR:refactors
Apr 6, 2023
Merged

execute: code refactors related to steam/defer#3878
IvanGoncharov merged 6 commits intographql:mainfrom
yaacovCR:refactors

Conversation

@yaacovCR
Copy link
Copy Markdown
Contributor

@yaacovCR yaacovCR commented Apr 5, 2023

extracted from #3862

yaacovCR added 6 commits April 5, 2023 04:33
@yaacovCR
introduce FieldGroup type
3e4fde0
@yaacovCR
rename fieldNodes variable to fieldGroup
2eb67bb 
to match type
@yaacovCR
introduce GroupedFieldSet type
52ccb18
@yaacovCR
use groupedFieldSet as variable name
93989eb 
to match type
@yaacovCR
refactor handleFieldError
ccca251 
= integrate locatedError, which was always called on the input
= avoid constant return value, which causes return value to hide value of this constant
= add optional asyncPayloadRecord parameter so that caller does not have to supply errors list
@yaacovCR
rename executeStreamIterator
566c29e 
to executeStreamAsyncIterator
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 5, 2023 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 566c29e
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/642cd1ff2047e3000881d939
😎 Deploy Preview https://deploy-preview-3878--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2023

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR requested a review from a team April 5, 2023 01:43
@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Apr 5, 2023
@github-advanced-security
Copy link
Copy Markdown

github-advanced-security AI commented Apr 5, 2023

You have successfully added a new CodeQL configuration .github/workflows/pull_request.yml:codeql. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@yaacovCR
Copy link
Copy Markdown
Contributor Author

yaacovCR commented Apr 5, 2023 •
edited
Loading

meant for each commit to be added separately, i.e. "rebase and merge" rather than "squash and merge"

IvanGoncharov
IvanGoncharov approved these changes Apr 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaacovCR Thanks for splitting it into separate commits; it was a pleasure to review.

@IvanGoncharov IvanGoncharov merged commit fab6426 into graphql:main Apr 6, 2023
@IvanGoncharov IvanGoncharov changed the title code refactors execute: code refactors related to steam/defer Apr 6, 2023
@yaacovCR yaacovCR mentioned this pull request May 15, 2023
Merged
yaacovCR added a commit that referenced this pull request May 16, 2023
@yaacovCR
executeFields: update grouped field set variable name (#3896)
e17a089 
missed by me both in #3891 and #3878
@yaacovCR yaacovCR mentioned this pull request Mar 20, 2024
Closed
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 11, 2025
@yaacovCR
executeFields: update grouped field set variable name (graphql#3896)
b1a0d20 
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 13, 2025
@yaacovCR
executeFields: update grouped field set variable name (graphql#3896)
9475dc4 
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
executeFields: update grouped field set variable name (graphql#3896)
b2c3947 
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025
@yaacovCR
executeFields: update grouped field set variable name (graphql#3896)
897de0d 
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
executeFields: update grouped field set variable name (graphql#3896)
fd287c3 
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
executeFields: update grouped field set variable name (graphql#3896)
6c778f7 
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 22, 2025
@yaacovCR
executeFields: update grouped field set variable name (graphql#3896)
becc509 
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit that referenced this pull request Dec 22, 2025
@yaacovCR
executeFields: update grouped field set variable name (#3896)
da38c89 
missed by me both in #3891 and #3878
yaacovCR added a commit that referenced this pull request Dec 22, 2025
@yaacovCR
executeFields: update grouped field set variable name (#3896)
0acfd26 
missed by me both in #3891 and #3878
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Jan 27, 2026
@yaacovCR
executeFields: update grouped field set variable name (graphql#3896)
ee17325 
missed by me both in graphql#3891 and graphql#3878
yaacovCR added a commit that referenced this pull request Feb 22, 2026
@yaacovCR
executeFields: update grouped field set variable name (#3896)
0ce0a0d 
missed by me both in #3891 and #3878
yaacovCR added a commit that referenced this pull request Feb 23, 2026
@yaacovCR
executeFields: update grouped field set variable name (#3896)
d9a312d 
missed by me both in #3891 and #3878
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
executeFields: update grouped field set variable name (#3896)
beab79b 
missed by me both in #3891 and #3878
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
executeFields: update grouped field set variable name (#3896)
a9cf8a1 
missed by me both in #3891 and #3878
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
executeFields: update grouped field set variable name (#3896)
1ca6ccb 
missed by me both in #3891 and #3878
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
executeFields: update grouped field set variable name (#3896)
2481dad 
missed by me both in #3891 and #3878
@yaacovCR yaacovCR deleted the refactors branch March 29, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robrichard robrichard robrichard approved these changes

@IvanGoncharov IvanGoncharov IvanGoncharov approved these changes

@saihaj saihaj saihaj approved these changes

Assignees

No one assigned

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yaacovCR @github-advanced-security @robrichard @IvanGoncharov @saihaj